Add dependencies used by PackageTests to exe:cabal-tests
#9397
Conversation
|
Another fix I have considered is to add all dependencies of However, I believe a better long-term solution could be to generate a .ghc.environment file instead of all this compile-time magic in the custom setup. |
|
The fix is, btw, wrong/incomplete. It doesn't fix other issues with the same origin, e.g. #5743. It could be extended to be fixed in the same way, but that's just adding plasters. I think it would be nicer to generate a .ghc.environment file and make |
|
@fendor: in that case, is this PR a draft? So that we don't merge it by mistake until you are ready... |
|
@Mikolaj This kind of depends on the active maintainers. I think this should fix CI for immediate issues. However, I think it would be better to migrate the test suite to use environment files. So, whether you merge this PR depends on whether this bug fix is critical right now. |
|
My opinion is that it's an important stop-gap fix that should be merged ASAP. |
|
I see. Then I'm inclined to merge it ASAP as well, but I've asked in the issue ticket just in case and in the interest of transparency. |
|
@Mikolaj that makes sense, thank you! |
|
Nobody came up with a solution that fixes everything from the grounds up, so @fendor, you are our only hope at this time. :) Please go ahead and set the label. |
mergify
bot
added
the
merge delay passed
|
Let me prod mergify... |
|
@mergify rebase |
❌ Base branch update has failed
|
|
Huh, I do still can login. Let me insist... |
|
@mergify rebase |
❌ Base branch update has failed
|
|
@mergify refresh |
✅ Pull request refreshed |
|
@Mergifyio rebase |
❌ Base branch update has failed
|
|
@Mergifyio requeue default |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
I've tried some commands directly from the dashboard, but they seem to do the same thing as from ticket comments (and show up the same and fail the same). |
|
@fendor: if you feel like it, please kindly rebase manually and merge manually. It may take us a while to diagnose mergify here. No rush, though. |
|
@mergify rebase |
❌ Base branch update has failed
|
|
Let me take the liberty and rebase vis the "Update branch" [edit: rather, "Rebase branch"] button (but first let me try mergify one last time). |
|
@mergify rebase |
❌ Base branch update has failed
|
Mikolaj
force-pushed
the
ci/issue-8365
branch
from
bb3e4b9 to
9794e5e
Compare
|
Looks fine now, just waiting in the queue (one more PR ahead). |
|
@mergify rebase |
❌ Base branch update has failed
|
|
Again the same story (too long on the queue, I guess?). Let's repeat the cure. |
The runner allows the tests to use extra dependencies and the custom Prelude from 'cabal-testsuite'. However, if the tests use a dependency, say 'directory', and there are two packages with the same unit id available in the store, the test fails since it doesn't know which one to pick. By including an extra dependency to directory, we force the test runner to use a specific version directory, fixing the test failure.
Mikolaj
force-pushed
the
ci/issue-8365
branch
from
9794e5e to
b83cc31
Compare
The runner allows the tests to use extra dependencies and the custom Prelude from 'exe:cabal-tests'.
However, if the tests use a dependency, say 'directory', and there are two packages with the same unit id available in the store, the test fails since it doesn't know which one to pick.
By including an extra dependency to directory, we force the test runner to use a specific version directory, fixing the test failure.
POC fix for #8356
Please read Github PR Conventions and then fill in one of these two templates.
Include the following checklist in your PR: