Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make check recognise TypeAbstractions #9504

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Make check recognise TypeAbstractions #9504

merged 1 commit into from
Dec 9, 2023

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Dec 8, 2023 •
edited
Loading

See #9496, backport of #9502.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

QA notes

  • create a new package
  • put TypeAbstractions in default-extensions
  • run cabal check
  • it should not complain about “Uknown extensions”.

@ffaf1
Make check recognise TypeAbstractions
25f972d 
See haskell#9496.

“Backport” of haskell#9502, notice that we are not adding a new constructor,
just tweaking `check` behaviour.  This is improve UX without breaking
changes.
@ffaf1 ffaf1 force-pushed the add-extension-3.10 branch from 75785c9 to 25f972d Compare December 8, 2023 08:28
@ffaf1 ffaf1 marked this pull request as ready for review December 8, 2023 09:01
Mikolaj
Mikolaj approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a true hack. :) Thank you so much.

@ffaf1 ffaf1 added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Dec 9, 2023
@mergify mergify bot merged commit 3f51173 into haskell:3.10 Dec 9, 2023
41 checks passed
@ffaf1 ffaf1 deleted the add-extension-3.10 branch December 12, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
backport cabal-install: cmd/check merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffaf1 @Mikolaj