-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add further tests of cyclical project imports #9665
Add further tests of cyclical project imports #9665
Conversation
cabal-testsuite/PackageTests/ConditionalAndImport/cyclical-2-out-out-back-a.config
Show resolved
Hide resolved
cabal-testsuite/PackageTests/ConditionalAndImport/cyclical-2-out-out-back-b.config
Show resolved
Hide resolved
cabal-testsuite/PackageTests/ConditionalAndImport/cyclical-2-out-out-backback-a.config
Show resolved
Hide resolved
cabal-testsuite/PackageTests/ConditionalAndImport/cyclical-2-out-out-backback-b.config
Show resolved
Hide resolved
cabal-testsuite/PackageTests/ConditionalAndImport/cyclical-2-out-out-self-a.config
Show resolved
Hide resolved
cabal-testsuite/PackageTests/ConditionalAndImport/cyclical-2-out-out-self-b.config
Show resolved
Hide resolved
Thanks @geekosaur, I've added newlines where they were missing in all files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, let's expedite this PR.
@philderbeast: please kindly rebase/squash/redo commits as you see fit and please set the labels, including the delay_passed label. |
- Assert on exact cyclical import failure message - Add logging and assertOutputContains to cyclical tests - Use a different naming convention for cyclical import tests - Use "self" in naming - Show import tree
3dbe09b
to
3f92ac6
Compare
Thanks @Mikolaj. I've squashed down to two commits, one that adds |
Label merge+no rebase is necessary when the pull request is from an organisation. |
While reviewing #9578, I saw that the cyclical test didn't
assertOutputContains
and had but one cyclical test, a simple loopback of a project importing itself. It now has the following test projects;