-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI updates (drop 8.4.4, update old-ghcs, update bootstrap plans) #9722
Conversation
mpickering
commented
Feb 16, 2024
- ci: Drop validate 8.4.4 job.
- Add 8.4.4, 8.2.2 and 8.0.2 to old-ghcs validation
- Update bootstrap plans: 8.10.7, 9.0.2, 9.2.8, 9.4.8, 9.6.4, 9.8.1
a2e68c2
to
8080105
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It might be worth keeping to test that cabal-install can use an old GHC (even if it is itself built with a newer compiler). "compiled with" and "can use" are orthogonal axes. |
There are the "old-ghcs" jobs but those only test the At the moment there is not CI configuration to test cabal-install with versions of GHC other than those which it has been built with. That seems worthy of another ticket but seems outside the scope of this MR. |
We no longer support 8.4.4 as it is older than three years. cabal-install can still be used with 8.4.4, but just not built with it, and this is tested by the old-ghcs jobs.
We were missing coverage from running tests with these ghc versions.
And add the relevant CI jobs for these plans
It fails in the old-ghcs 8.4.4 configuration, and debugging why seems to have very little pay-off for this niche feature in a very old configuration.