Update licence list

[ffaf1]

Per https://github.com/haskell/cabal/wiki/Updating-the-license-list to version 3.23 (2024-02-08) of SPDX License List.

---

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.
• not necessary ~~Manual QA notes have been included.
• not needed Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

[ffaf1]

After yesterday’s call with Mikolaj, I think this step has to be done before the “bumping version numbers” one.
Let us see what CI says.

A thing that was not mentioned in the wiki is whether this should be forwardported to master.

[ffaf1]

I forgot about this. I will add merge delay passed, since three days have gone by.

[Mikolaj]

Thank you.

[Mikolaj]

I'm guessing this should have been done on master and backported. The old wiki page had "note: most of the changes should be done on branch master and backported to the release branch." I guess we should add this to each and every point except the one or two that are best done on release branch [edit: and forward-ported].

BTW, mergify seems stuck, so let me merge manually.

[Mikolaj]

@mergify rebase

[mergify]

rebase

✅ Nothing to do for rebase action

[Mikolaj]

@mergify refresh

[mergify]

refresh

✅ Pull request refreshed

[Mikolaj]

@mergify unqueue

[mergify]

unqueue

☑️ The pull request is not queued

[Mikolaj]

@mergify requeue

[Mikolaj]

@mergify queue

[Mikolaj]

@mergify enqueue

[mergify]

requeue

❌ This pull request head commit has not been previously disembarked from queue.

[mergify]

enqueue

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e867d30

[Mikolaj]

Hah, queue worked.

[ffaf1]

@mergify backport master

[mergify]

backport master

✅ Backports have been created

• #9836 Update licence list (backport #9818) has been created for branch master

[ulysses4ever]

@ffaf1 two points on interest.

First,

I will add merge delay passed, since three days have gone by.

The delay is not required for PRs against branches other than master. This is just FYI.

Second, this manual backport has a subtle difference from the original (#9837): the json files in license-list-data don't have newlines at the end. Compare:

• master version
• 3.12 version

Just wanted to share my pain: I spent half a day banging my head against the whitespace GH workflow that fails on 3.12 and works on master because of this subtlety...

[geekosaur]

The delay is not required for PRs against branches other than master. This is just FYI.

IIRC it's only waived for PRs that are identified as backports.

[ulysses4ever]

@geekosaur good point. By reading https://github.com/haskell/cabal/blob/master/.github/mergify.yml it appears that if you manually put the backport label, it will do the trick. In this case, it is a manual backport, so the label is justified. But perhaps we should simplify it, since with the current setup, a vanilla (non-backport) PR against a non-master branch will not be served by the bot at all, it looks like.