Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin index-state in both release and validate project files #9820

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Pin index-state in both release and validate project files #9820

merged 1 commit into from
Mar 21, 2024

Conversation

Kleidukos
Copy link
Member

cf: #9819

@Kleidukos Kleidukos mentioned this pull request Mar 19, 2024
Closed
@Mikolaj
Copy link
Member

Mikolaj commented Mar 19, 2024

Why also in cabal.project.validate?

@Mikolaj
Copy link
Member

Mikolaj commented Mar 19, 2024

Oh, I see the discussion in #9819. Let me continue there.

@Kleidukos Kleidukos mentioned this pull request Mar 20, 2024
Open
Mikolaj
Mikolaj approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A per discussion in the issue ticket, I think merging this is fine.

@Kleidukos Kleidukos merged commit f9a1dd7 into haskell:3.10 Mar 21, 2024
37 checks passed
@Kleidukos Kleidukos deleted the pin-index-in-3.10-release-and-validation branch March 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kleidukos @Mikolaj @geekosaur