Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: force MacOS jobs to use Intel runners (macos-13) (backport #9949) #9956

Merged
merged 5 commits into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions .github/workflows/bootstrap.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,28 +52,18 @@ jobs:
restore-keys: bootstrap-${{ runner.os }}-${{ matrix.ghc }}-20221115-

- uses: actions/checkout@v4
# See https://github.com/haskell/cabal/pull/8739
- name: Sudo chmod to permit ghcup to update its cache
run: |
if [[ "${{ runner.os }}" == "Linux" ]]; then
sudo ls -lah /usr/local/.ghcup/cache
sudo mkdir -p /usr/local/.ghcup/cache
sudo ls -lah /usr/local/.ghcup/cache
sudo chown -R $USER /usr/local/.ghcup
sudo chmod -R 777 /usr/local/.ghcup
fi
- uses: haskell-actions/setup@v2
with:
ghc-version: ${{ matrix.ghc }}

- name: bootstrap.py
run: |
GHC_VERSION=${{ matrix.ghc }}
ghcup --version
ghcup config set cache true
ghcup install ghc $GHC_VERSION

# Fetch the bootstrap sources (we use linux dependencies also on macos)
python3 bootstrap/bootstrap.py -w $(ghcup whereis ghc $GHC_VERSION) -d bootstrap/linux-$GHC_VERSION.json fetch
python3 bootstrap/bootstrap.py -d bootstrap/linux-$GHC_VERSION.json fetch

# Bootstrap using the bootstrap sources
python3 bootstrap/bootstrap.py -w $(ghcup whereis ghc $GHC_VERSION) --bootstrap-sources bootstrap-sources.tar.gz
python3 bootstrap/bootstrap.py --bootstrap-sources bootstrap-sources.tar.gz

- name: Smoke test
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
GHC_FOR_RELEASE: ${{ format('["{0}"]', env.GHC_FOR_RELEASE) }}
strategy:
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
os: ["ubuntu-latest", "macos-13", "windows-latest"]
# If you remove something from here.. then add it to the old-ghcs job.
ghc: ["9.8.2", "9.6.4", "9.4.8", "9.2.8", "9.0.2", "8.10.7", "8.8.4", "8.6.5"]
geekosaur marked this conversation as resolved.
Show resolved Hide resolved
exclude:
Expand Down
4 changes: 2 additions & 2 deletions cabal-testsuite/PackageTests/Manpage/cabal.test.hs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ main = cabalTest $ do
assertOutputContains ".B cabal install" r
assertOutputDoesNotContain ".B cabal manpage" r

-- The following test of `cabal man` needs `nroff` which is not available under Windows.
unless (buildOS == Windows) $ do
-- The following test of `cabal man` needs `nroff` which is not available under Windows and OSX.
unless (buildOS == Windows || buildOS ==OSX) $ do

-- Check that output of `cabal man --raw` can be passed through `nroff -man`
-- without producing any warnings (which are printed to stderr).
Expand Down
3 changes: 3 additions & 0 deletions cabal-testsuite/src/Test/Cabal/Server.hs
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ import qualified GHC.IO.Exception as GHC
import Distribution.Verbosity

import System.Process.Internals
( ProcessHandle__( OpenHandle )
, withProcessHandle
)
#if mingw32_HOST_OS
import qualified System.Win32.Process as Win32
#endif
Expand Down
Loading