Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internals into a separate package #192

Open
hasufell opened this issue Mar 19, 2023 · 3 comments
Open

Move internals into a separate package #192

hasufell opened this issue Mar 19, 2023 · 3 comments

Comments

@hasufell
Copy link
Member

Following:

The move could be considered a breaking change.

It's also not entirely clear what the process/impact is, since we're dealing with a boot package.

@Bodigrim @bgamari @mpickering

@Bodigrim
Copy link
Contributor

It's also not entirely clear what the process/impact is, since we're dealing with a boot package.

One would have to add a new submodule and patch Hadrian to pick it up, but I do not expect any blockers.

@jdkr
Copy link

jdkr commented Apr 2, 2023

There's one question that arises to me. What would be considered as Internal? Only the modules named Internal, or the whole tree of modules located under System.OsPath and System.OsString?
As far as I understand, the modules in OsPath are the implementation of the Abstract File Path Proposal (which may change in the future) and the modules in OsString are platform specific. Both I would consider Internal.

@hasufell
Copy link
Member Author

#200

hasufell added a commit that referenced this issue Jul 25, 2023
hasufell added a commit that referenced this issue Jul 25, 2023
hasufell added a commit that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants