GHC.IO.Handle.Lock #207
Merged
GHC.IO.Handle.Lock #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
force-pushed
the
ghc-io-handle-lock
branch
2 times, most recently
from
d2084b2 to
74a1a8c
Compare
|
Indeed, this one's a much better provisional solution as it avoids introducing a new bug (the #205 regression). |
hvr
reviewed
Feb 14, 2018
| import Control.Exception (Exception) | ||
| import Data.Typeable | ||
|
|
||
| #if defined(solaris2_HOST_OS) |
hvr
reviewed
Feb 14, 2018
|
|
||
| ---------------------------------------- | ||
|
|
||
| #if defined(solaris2_HOST_OS) |
phadej
force-pushed
the
ghc-io-handle-lock
branch
2 times, most recently
from
921650c to
ef5f713
Compare
|
aix disabled too. |
This reverts commit d91afd3.
phadej
force-pushed
the
ghc-io-handle-lock
branch
from
ef5f713 to
a593d70
Compare
Does d91afd3 in better way See also haskell/cabal#5072 for discussion about locking. TL;DR if we want to use fcntl, we have to make proper implementation and audit it. The directory creation fallback will be used on at least Solaris and AIX
phadej
force-pushed
the
ghc-io-handle-lock
branch
from
a593d70 to
2a1a6cc
Compare
phadej
force-pushed
the
ghc-io-handle-lock
branch
from
346ef3d to
a457de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are to use stopgap solution., let's use better one.