Publishing a candidate does not transfer already-built docs

[edsko]

When publishing a candidate the resulting official package does not have any built docs, even if the original candidate did. The doc builder will attempt to rebuild them of course, but it might not be able to.

[gracenotes]

As far as maybe the best way to do this: separate publishing out into a separate feature, to have dependencies on both candidate and non-candidate versions of the documentation feature.

[expipiplus1]

As far as I can tell, candidates are published by getting the path to the tarball and "uploading" that again. So to fix this it would require finding the documentation tarball and "uploading" it here:

hackage-server/Distribution/Server/Features/PackageCandidates.hs

Line 465 in 985c1ee

return uresult

[gbaz]

@sitaochen did we look at this during gsoc?

[sitaochen]

Yea, the uploaded docs of candidates will also be there after they are published.

[expipiplus1]

oh great, so this can be closed?

[liskin]

I don't think this can be closed. I just published X11-1.10 which had docs uploaded to the candidate and the published release doesn't have the docs: https://hackage.haskell.org/package/X11-1.10
Can someone take a look what's going on under the hood?

(I later uploaded the docs manually so the docs are there now, but initially there were no docs and a while later a build error appeared. So the docs are definitely not being taken from the candidate.)