Night mode fixes #1163
Night mode fixes #1163
Conversation
|
looking at haskell/haddock#790 (comment) |
|
Right. just build a doc tarball with quickjump enabled, then upload it. No need to run a docbuilder instance yourself etc. |
|
Big improvement, @gbaz please review
|
|
Also testing this on prod. Looks much better! Still not perfect, imho -- the light blue of the shortcut keys isn't great, and the highlighting when mousing-over a search result washes out the light text. However, its certainly much more usable than before. Now that we have this and the other set of changes on prod, I think the immediate urgency has passed. I'd certainly like to see some future work to make this really nice, based on your own (good) taste and user feedback, but there's no rush, and its around midnight my time, so I certainly don't intend to think about this for the next little bit :-) Cheers! |
|
@gbaz , agreed, I will improve it further later. Thank you for your critical assistance and project leadership! Have a great weekend |
|
Closes: #1167 I could not reproduce this issue with the Firefox dev tools, but probably fixed by a9ca79c Could be further improved: https://stackoverflow.com/questions/7187569/difference-in-applying-css-to-html-body-and-the-universal-selector
|
|
@gbaz , can we merge this now to close #1167 and make the other fixes #1163 (comment) later? |
|
@peterbecich : Are these commits self-contained and should be preserved, or should we squash&merge them? |
|
@andreasabel , squash would be good |
Night mode fixes