Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that haddock docs build completed before uploading (fixes #119). #129

Merged
merged 1 commit into from
Oct 22, 2013
Merged

Check that haddock docs build completed before uploading (fixes #119). #129

merged 1 commit into from
Oct 22, 2013

Conversation

komadori
Copy link
Contributor

I've created a patch which extends the existing checks in BuildClient.hs:buildPackage to check that the desired-package-name.haddock file exists in the output before uploading docs.tar. The existing check was insufficient and allowed hackage-build to upload docs even when the package has failed to build, provided that at least one dependency succeeded. This fixes issue #119 insofar as hackage-build should stop uploading bad docs.

dcoutts added a commit that referenced this pull request Oct 22, 2013
Check that haddock docs build completed before uploading (fixes #119).
@dcoutts dcoutts merged commit 5cf35c3 into haskell:master Oct 22, 2013
@dcoutts
Copy link
Contributor

dcoutts commented Oct 22, 2013

Thanks. Though I'm still concerned about the doc tarballs containing many more files that necessary. Is that still the case? Also, are we generating the hoogle .txt files?

@komadori
Copy link
Contributor Author

Yes, it's still the case that the docs tar-ball contains unused documentation for dependencies and I created issue #130 to track the resolution of that problem. I plan to fix that too if no one else does first, but I haven't got around to it yet. I don't think any Hoogle databases are generated as I don't see them in the tarball and the build client doesn't appear to pass the --hoogle option to Haddock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants