Check that haddock docs build completed before uploading (fixes #119). #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a patch which extends the existing checks in BuildClient.hs:buildPackage to check that the desired-package-name.haddock file exists in the output before uploading docs.tar. The existing check was insufficient and allowed hackage-build to upload docs even when the package has failed to build, provided that at least one dependency succeeded. This fixes issue #119 insofar as hackage-build should stop uploading bad docs.