Enhance Tagging feature #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UI for proposing tag changes - Clickable UI for accepting/rejecting tags - Add GET method to /package/:pkgname/tags - Categories are parsed into tags - Tag aliasing support (When a trustee aliases Tag abcd -> Tag abc, all packages that were earlier tagged `abcd` get tagged to `abc` and any new packages tagged `abcd` get retagged `abc` on upload) This has been factored out of the HSoC work haskell#514 by @sooryan The code has been refactored & cleaned up by Duncan, Gershom and Herbert.
gbaz
approved these changes
Aug 27, 2017
|
Things we may want to consider doing: adding I was a bit worried about cycles in tag aliases, but after reading the code carefully and seeing how they're linearized for update, it won't actually cause problems, and the latest will just win. Future work could include a better interface for reviewing current aliases or displaying them. Also, future work related to #230 is to add notifications to maintainers for proposed tag additions, and also putting those together on a "maintainer/trustee" dashboard page whenever that's created. Absent that, proposed tags may well get lost in the ether... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI for proposing tag changes
Clickable UI for accepting/rejecting tags
Add GET method to /package/:pkgname/tags
Categories are parsed into tags
Tag aliasing support
(When a trustee aliases Tag abcd -> Tag abc, all packages that were earlier
tagged
abcdget tagged toabcand any new packages taggedabcdgetretagged
abcon upload)This has been factored out of the HSoC work #514 by @sooryan
The code has been refactored & cleaned up by Duncan, Gershom and Herbert.