Skip to content

Fix search bugs #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Fix search bugs #736

merged 1 commit into from
Apr 30, 2018

Conversation

gbaz
Copy link
Contributor

@gbaz gbaz commented Apr 1, 2018

This fixes two bugs in search -- first by not concating component strings of markdown, but instead joining them with whitespace (pre-tokenization). Second a stupid order-of-arguments error that meant the extra stemming added in #633 wasn't working properly. This should go a fair way to addressing #615

@hvr
Copy link
Member

hvr commented Apr 1, 2018

@gbaz does this address that base64 issue I mentioned?

@hvr hvr merged commit c574405 into master Apr 30, 2018
@hvr hvr deleted the gb/fixsearch branch April 30, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants