Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Fix warnings #159

Closed
cocreature opened this issue Jan 5, 2016 · 2 comments
Closed

Fix warnings #159

cocreature opened this issue Jan 5, 2016 · 2 comments

Comments

@cocreature
Copy link
Collaborator

We seem to have accumulated some warnings, most of which are probably completely unnecessary (like unnecessary imports), so it would be great if someone could go through them and fix them.

This sounds like a nice issue to get started with hie development.

One thing that’s annoying about this is that we can’t just use --pedantic since stack also enables the flags for extra-deps, but that is supposed to be fixed.

@glittershark
Copy link
Contributor

Any interest in setting -Werr on CI so this doesn't happen again?

@cocreature
Copy link
Collaborator Author

Theoretically: absolutely, I think we even had that some point.

Particallly: Not an potion atm because stack will also set -Werr for all extra-deps which causes the build to fail since some of them don’t compile with -Werr. We should be able to get rid of the extra-deps rather soon and the stack guys also said they’re going to change this so when either of those happens, we should definitely do that again.

rasendubi added a commit to rasendubi/haskell-ide-engine that referenced this issue Jan 9, 2016
@rasendubi rasendubi mentioned this issue Jan 9, 2016
rasendubi added a commit to rasendubi/haskell-ide-engine that referenced this issue Jan 9, 2016
rasendubi added a commit to rasendubi/haskell-ide-engine that referenced this issue Jan 9, 2016
@alanz alanz added this to the prehistory milestone Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants