Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Make all ToJSON instances clearly visible #32

Closed
alanz opened this issue Nov 7, 2015 · 2 comments
Closed

Make all ToJSON instances clearly visible #32

alanz opened this issue Nov 7, 2015 · 2 comments
Labels
Well Defined Task - Awaiting PR
Milestone
prehistory

Comments

@alanz
Copy link
Collaborator

alanz commented Nov 7, 2015

Because JSON is used for external interfaces for many of the transports, the JSON generated must be stable. Hence it should not be generated by automated means that may change with compiler or library version.

Replace all ToJSON instances with hand-written ones, which make the encoding explicit.
@gracjan gracjan mentioned this issue Nov 7, 2015
Merged
@bitemyapp
Copy link
Collaborator

Concur with this. Manual JSON instances are best.

@alanz
Copy link
Collaborator Author

alanz commented Nov 7, 2015

PR's welcome :)

On Sat, Nov 7, 2015 at 10:02 PM, Chris Allen notifications@github.com
wrote:

Concur with this. Manual JSON instances are best.

—
Reply to this email directly or view it on GitHub
#32 (comment)
.

cocreature added a commit to cocreature/haskell-ide-engine that referenced this issue Nov 7, 2015
@cocreature
Handwrite ToJSON instances, fix haskell#32
6345a5b
@alanz alanz closed this as completed in 29dd387 Nov 8, 2015
alanz added a commit that referenced this issue Nov 8, 2015
@alanz
Merge pull request #35 from cocreature/json-instances
5675072 
Handwrite ToJSON instances, fix #32
@mgsloan mgsloan mentioned this issue Nov 28, 2015
Closed
@alanz alanz added this to the prehistory milestone Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Well Defined Task - Awaiting PR
Projects
None yet
Milestone
prehistory
Development

No branches or pull requests
2 participants
@bitemyapp @alanz