This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Read files in UTF8 mode #1020
Merged
Read files in UTF8 mode #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone please test this on a mac? And I am worried about the non-utf8 files on windows too. |
Why, tho. AFAIK, GHC assumes input files are utf-8 anyway. |
|
I am planning on doing a release today, will merge this after, so people using the "stable" version don't get hit by any funnies, and then people using the master version will be able to provide feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #667
Via alanz/ghc-mod#15