This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Detect plugin param name collisions #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led ones in PluginUtilsSpec after changing the return type of validatePlugins to Maybe Error
| @@ -9,10 +9,16 @@ module Haskell.Ide.Engine.PluginUtils | |||
| , mapEithers | |||
| , missingParameter | |||
| , incorrectParameter | |||
| , validatePlugins | |||
There was a problem hiding this comment.
I do not believe this funcionality belongs in hie-plugin-api, it will only be used when a plugin is integrated, so belongs either in Haskell.Ide.Engine.Dispatcher or a Haskell.Ide.Engine.Utils file in the same place.
|
Looks good. Just a few housekeeping issues. |
… Perform validation in main, before the dispatcher runs
|
Good points, @alanz, I've made the changes :) |
|
Thanks, looks great |
alanz
added a commit
that referenced
this pull request
Dec 2, 2015
Detect plugin param name collisions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
I highly appreciate feedback on style/readability etc. :)