This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Ghc mod find #135
Merged
Ghc mod find #135
+46
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We fork() the dump symbol table function because of a memory leak in GHC FYI. |
|
@DanielG does the leak occur in all GHC versions? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the find command since it was a placeholder. The issue was that the find command in ghc-mod launches another copy of the executable. The source doesn't say why, and if dumping the symbol file in the same session should be avoided. It works without it: I basically just copied the code from findSymbol. The return type is a
ModuleList, a specific type added to SemanticTypes.A side effect is that CtxProject does require the project directory, since we need it for ghc-mod. So there's a
dirparameter for CtxProject commands. Its type is stillPtFile, not sure it's worth creating a differentPtDirparameter type.