This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Hare context #141
Merged
Hare context #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -> String -- ^ command name for log | ||
| -> (RefactSettings -> GM.Options -> FilePath -> IO [FilePath]) | ||
| -> IdeM (IdeResponse RefactorResult) | ||
| runHareCommand fp name cmd = do |
There was a problem hiding this comment.
I wonder if we shouldn't pull this into PluginUtils or MonadFunctions, to run a GhcModT action in an appropriate directory.
There was a problem hiding this comment.
Yes, I've started putting stuff in there (fileInfo, catchException).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed via IRC, hare needs to be in the right folder. With this change, running a refactor command from Leksah generates a right answer (a diff). Progress!