Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Support more commands #145

Merged
merged 6 commits into from
Dec 22, 2015
Merged

Support more commands #145

merged 6 commits into from
Dec 22, 2015

Conversation

cocreature
Copy link
Collaborator

This is a bunch of different things but they built upon each other so splitting it up doesn’t really gain us anything.

In particular the generated functions now have docstrings, parameters and ask for the required paramaters when called interactively. Apart from that I also added support for the refactor type returned by hare-rename (and probably also a lot of the other hare commands, that was just what I tested). Currently I just overwrite the old buffer content. I know at least @alanz would like to have an ediff window so we should add an option like hie-refactor-confirm which when enabled causes an ediff window to pop up. There’s nothing particularly difficult about adding that, I simply haven’t gotten around to it yet. Imho that can be done in a separate commit as in the disucssions it seemed like most people just want the buffer to be overwritten.

@alanz
Copy link
Collaborator

alanz commented Dec 22, 2015

@cocreature it may be enough to just show the patch in a buffer, as a preview. even after the fact, given undo capability

@cocreature
Copy link
Collaborator Author

@alanz The patch is already written to the *hie-refactor* buffer. So if you just want to inspect it it’s easy.

@alanz
Copy link
Collaborator

alanz commented Dec 22, 2015

ok, sounds good.

cocreature added a commit that referenced this pull request Dec 22, 2015
@cocreature cocreature merged commit 5001a17 into haskell:master Dec 22, 2015
@alanz alanz added this to the prehistory milestone Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants