This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of different things but they built upon each other so splitting it up doesn’t really gain us anything.
In particular the generated functions now have docstrings, parameters and ask for the required paramaters when called interactively. Apart from that I also added support for the refactor type returned by hare-rename (and probably also a lot of the other hare commands, that was just what I tested). Currently I just overwrite the old buffer content. I know at least @alanz would like to have an ediff window so we should add an option like
hie-refactor-confirm
which when enabled causes an ediff window to pop up. There’s nothing particularly difficult about adding that, I simply haven’t gotten around to it yet. Imho that can be done in a separate commit as in the disucssions it seemed like most people just want the buffer to be overwritten.