This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Improve error messages in JSON parsing #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Aeson's built-in `with<type>` functions, plus a custom error message
at the end of the ParamValP parser's Alternative chain to improve error
messages when parsing JSON requests.
Before:
-------
```
❯ echo '{"cmd":"base:commands","params":{"plugin": "hare"}}' | hie
--one-shot | jq
{
"error": {
"msg": "FromJSONError \"failed to parse field params: empty\"",
"code": "ParseError",
"info": null
}
}
```
After:
------
```
❯ echo '{"cmd":"base:commands","params":{"plugin": "hare"}}' | stack exec -- hie --one-shot | jq
{
"error": {
"msg": "FromJSONError \"failed to parse field params: expected text, file, or position object, encountered String\"",
"code": "ParseError",
"info": null
}
}
```
Closes haskell#166
| parseJSON _ = mzero | ||
| parseJSON = withObject "WireRequest" $ \v -> | ||
| WireReq <$> | ||
| v A..: "cmd" <*> |
There was a problem hiding this comment.
worth not importing Aeson qualified here to make this consistent with the other files in the repo?
Don't qualify Data.Aeson here, since it's not qualified anywhere else
|
@cocreature no longer qualifying Data.Aeson in that module |
cocreature
added a commit
that referenced
this pull request
Jan 12, 2016
Improve error messages in JSON parsing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Aeson's built-in
with<type>functions, plus a custom error messageat the end of the ParamValP parser's Alternative chain to improve error
messages when parsing JSON requests.
Before:
After:
Closes #166