Fix warnings

.travis.yml

@@ -22,9 +22,8 @@ install:
 - "./travis_long stack +RTS -N2 -RTS setup"
 - "./travis_long stack build --only-snapshot"
 - "./travis_long stack install ide-backend-server"
-- "export PATH=\"${HOME}/.local/bin\":${PATH}"
 script:
-- "./travis_long stack +RTS -N1 -RTS build"
+- "STACK_YAML=stack_test.yaml ./travis_long stack +RTS -N1 -RTS build --test --no-run-tests"
 - "./travis_long stack +RTS -N1 -RTS build --test"
 - "./travis_long stack exec emacs24 -- -q --batch -L elisp -l elisp/tests/hie-tests.el
   -f ert-run-tests-batch-and-exit"

Makefile

@@ -5,16 +5,19 @@ ifeq (,$(shell which $(emacs) 2> /dev/null))
 endif
 
 .PHONY: test
-test: test-haskell test-emacs
+test: build-haskell test-haskell test-emacs
 
 .PHONY: test-emacs
 test-emacs:
 	stack exec $(emacs) -- -q --batch -L elisp -l elisp/tests/hie-tests.el -f ert-run-tests-batch-and-exit
 
 .PHONY: test-haskell
+build-haskell:
+	@STACK_YAML=stack_test.yaml stack build --test --no-run-tests
 test-haskell:
 	# stack build --test --pedantic
 	# stack complains about deprecations in ghc-mod as an extra dep
+# build with -Werror enabled but run the tests without it because ide-backend picks it up
 	stack build --test
 
 .PHONY: ghci-test

app/MainHie.hs

@@ -1,3 +1,5 @@
+{-# OPTIONS_GHC -fno-warn-partial-type-signatures #-}
+
 {-# LANGUAGE GADTs #-}
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE TemplateHaskell #-}

haskell-ide-engine.cabal

@@ -13,6 +13,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   hs-source-dirs:      src
   exposed-modules:     Haskell.Ide.Engine.BasePlugin
@@ -94,6 +98,8 @@ executable hie
                      , transformers
                      , vinyl
   ghc-options:         -threaded -rtsopts -with-rtsopts=-N -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010
 
 test-suite haskell-ide-test
@@ -135,6 +141,8 @@ test-suite haskell-ide-test
                      , unordered-containers
                      , vinyl
   ghc-options:         -threaded -rtsopts -with-rtsopts=-N -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010
 
 source-repository head

hie-apply-refact/Haskell/Ide/ApplyRefactPlugin.hs

@@ -1,3 +1,5 @@
+{-# OPTIONS_GHC -fno-warn-partial-type-signatures #-}
+
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE PartialTypeSignatures #-}
 {-# LANGUAGE OverloadedStrings #-}
@@ -17,8 +19,6 @@ import           Haskell.Ide.Engine.PluginUtils
 import           Haskell.Ide.Engine.SemanticTypes
 import           Language.Haskell.HLint3 as Hlint
 import           Refact.Apply
-import qualified Refact.Types as R
-import           Refact.Types hiding (SrcSpan)
 import           System.Directory
 import           System.IO.Extra
 
@@ -108,7 +108,7 @@ showParseError (Hlint.ParseError loc message content) = unlines [show loc, messa
 makeDiffResult :: FilePath -> T.Text -> IO HieDiff
 makeDiffResult orig new = do
   origText <- T.readFile orig
-  let (HieDiff f s d) = diffText (orig,origText) ("changed",new)
+  let (HieDiff f _ d) = diffText (orig,origText) ("changed",new)
   f' <- liftIO $ makeRelativeToCurrentDirectory f
   -- return (HieDiff f' s' d)
   return (HieDiff f' "changed" d)

hie-apply-refact/hie-apply-refact.cabal

@@ -11,6 +11,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   exposed-modules:     Haskell.Ide.ApplyRefactPlugin
   build-depends:       base >= 4.7 && < 5
@@ -30,4 +34,6 @@ library
                      , transformers
                      , vinyl >= 0.5 && < 0.6
   ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010

hie-base/hie-base.cabal

@@ -11,6 +11,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   exposed-modules:
                        Haskell.Ide.Engine.PluginTypes
@@ -24,4 +28,6 @@ library
                      , singletons
                      , vinyl
   ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010

hie-docs-generator/hie-docs-generator.cabal

@@ -16,6 +16,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 executable hie-docs-generator
   main-is:             Main.hs
   other-modules:       Options, Examples
@@ -39,4 +43,7 @@ executable hie-docs-generator
                      , pcre-heavy
                      , text
   hs-source-dirs:      src
-  default-language:    Haskell2010
+  ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
+  default-language:    Haskell2010

hie-docs-generator/src/Examples.hs

@@ -1,16 +1,10 @@
 {-# LANGUAGE OverloadedStrings #-}
 module Examples where
 
-import qualified Data.Aeson as A
-import qualified Data.ByteString.Lazy as BSL
 import qualified Data.Map as M
 import           Data.Monoid
-import qualified Data.Text as T
-import           Haskell.Ide.Engine.BasePlugin
-import           Haskell.Ide.HaRePlugin
 import           Haskell.Ide.Engine.PluginDescriptor
 import           Haskell.Ide.Engine.Transport.JsonStdio
-import           Options
 
 jsonStdioExample :: PluginId -> UntaggedCommandDescriptor -> WireRequest
 jsonStdioExample pluginId (CommandDesc{cmdName = name,cmdContexts = contexts,cmdAdditionalParams = cmdParams}) =

hie-docs-generator/src/Main.hs

@@ -13,13 +13,7 @@ import qualified Data.Text as T
 import qualified Data.Text.Encoding as T
 import qualified Data.Text.IO as T
 import           Examples
-import           Haskell.Ide.ApplyRefactPlugin
-import           Haskell.Ide.Engine.BasePlugin
 import           Haskell.Ide.Engine.PluginDescriptor
-import           Haskell.Ide.ExamplePlugin2
-import           Haskell.Ide.ExamplePluginAsync
-import           Haskell.Ide.GhcModPlugin
-import           Haskell.Ide.HaRePlugin
 import qualified Options as O
 import           Options.Applicative
 import           System.Directory
@@ -41,11 +35,11 @@ newtype DocGenM a =
 
 generateDocs :: DocGenM ()
 generateDocs =
-  do path <- pluginIndexPath
+  do indexPath <- pluginIndexPath
      index <- pluginIndex
      prefix <- asks O.prefix
      liftIO . createDirectoryIfMissing True $ prefix </> "plugins"
-     liftIO $ T.writeFile path index
+     liftIO $ T.writeFile indexPath index
      plugins <- asks O.plugins
      let pluginDocs = map pluginDoc $ M.toList plugins
      pluginDocPaths <- mapM pluginDocPath $ M.keys plugins

hie-eg-plugin-async/Haskell/Ide/ExamplePluginAsync.hs

@@ -1,3 +1,5 @@
+{-# OPTIONS_GHC -fno-warn-partial-type-signatures #-}
+
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE OverloadedStrings #-}
 {-# LANGUAGE GADTs #-}
@@ -8,13 +10,11 @@ import           Control.Concurrent
 import           Control.Concurrent.STM.TChan
 import           Control.Monad.IO.Class
 import           Control.Monad.STM
-import qualified Data.Map as Map
 import           Data.Monoid
 import qualified Data.Text as T
 import           Haskell.Ide.Engine.ExtensibleState
 import           Haskell.Ide.Engine.MonadFunctions
 import           Haskell.Ide.Engine.PluginDescriptor
-import           Haskell.Ide.Engine.PluginUtils
 
 -- ---------------------------------------------------------------------
 
@@ -64,7 +64,7 @@ instance ExtensionClass AsyncPluginState where
 
 -- | This command manages interaction with a separate process, doing stuff.
 longRunningCmdSync :: WorkerCmd -> CommandFunc T.Text
-longRunningCmdSync cmd = CmdSync $ \_ctx req -> do
+longRunningCmdSync cmd = CmdSync $ \_ctx _req -> do
   SubProcess cin cout _tid <- ensureProcessRunning
   liftIO $ atomically $ writeTChan cin cmd
   res <- liftIO $ atomically $ readTChan cout
@@ -95,6 +95,7 @@ ensureProcessRunning = do
 workerProc :: TChan WorkerCmd -> TChan T.Text -> IO ()
 workerProc cin cout = loop 1
   where
+    loop :: Integer -> IO ()
     loop cnt = do
       debugm "workerProc:top of loop"
       req <- liftIO $ atomically $ readTChan cin
@@ -111,7 +112,7 @@ workerProc cin cout = loop 1
 
 -- | This command manages interaction with a separate process, doing stuff.
 streamingCmdAsync :: WorkerCmdAsync -> CommandFunc T.Text
-streamingCmdAsync cmd = CmdAsync $ \replyFunc _ctx req -> do
+streamingCmdAsync cmd = CmdAsync $ \replyFunc _ctx _req -> do
   tid <- liftIO $ forkIO (workerProcAsync cmd replyFunc)
   debugm $ "streamingCmdAsync:launched worker as " ++ show tid
   let tidStr = T.pack (show tid ++ ":")

hie-eg-plugin-async/hie-eg-plugin-async.cabal

@@ -11,6 +11,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   exposed-modules:     Haskell.Ide.ExamplePluginAsync
   build-depends:       base >= 4.7 && < 5
@@ -21,4 +25,6 @@ library
                      , text
                      , transformers
   ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010

hie-example-plugin2/Haskell/Ide/ExamplePlugin2.hs

@@ -1,3 +1,5 @@
+{-# OPTIONS_GHC -fno-warn-partial-type-signatures #-}
+
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE PartialTypeSignatures #-}
 {-# LANGUAGE OverloadedStrings #-}

hie-example-plugin2/hie-example-plugin2.cabal

@@ -11,6 +11,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   exposed-modules:     Haskell.Ide.ExamplePlugin2
   build-depends:       base >= 4.7 && < 5
@@ -20,4 +24,6 @@ library
                      , text
                      , transformers
   ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010

hie-ghc-mod/Haskell/Ide/GhcModPlugin.hs

@@ -1,3 +1,5 @@
+{-# OPTIONS_GHC -fno-warn-partial-type-signatures #-}
+
 {-# LANGUAGE PartialTypeSignatures #-}
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE FlexibleContexts #-}
@@ -8,7 +10,6 @@ module Haskell.Ide.GhcModPlugin where
 
 import           Haskell.Ide.Engine.PluginUtils
 
-import           Control.Exception
 import           Control.Monad.IO.Class
 import           Data.Aeson
 import           Data.Either
@@ -18,7 +19,6 @@ import qualified Data.Text.Read as T
 import           Data.Vinyl
 import qualified Exception as G
 import           Haskell.Ide.Engine.PluginDescriptor
-import           Haskell.Ide.Engine.PluginUtils
 import           Haskell.Ide.Engine.SemanticTypes
 import qualified Language.Haskell.GhcMod as GM
 import qualified Language.Haskell.GhcMod.Monad as GM

hie-ghc-mod/hie-ghc-mod.cabal

@@ -11,6 +11,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   exposed-modules:     Haskell.Ide.GhcModPlugin
   build-depends:       base >= 4.7 && < 5
@@ -27,4 +31,6 @@ library
                      , vinyl >= 0.5 && < 0.6
 
   ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010

hie-hare/Haskell/Ide/HaRePlugin.hs

@@ -1,3 +1,5 @@
+{-# OPTIONS_GHC -fno-warn-partial-type-signatures #-}
+
 {-# LANGUAGE PartialTypeSignatures #-}
 {-# LANGUAGE DataKinds #-}
 {-# LANGUAGE OverloadedStrings #-}
@@ -143,10 +145,7 @@ makeRefactorResult changedFiles = do
     diffOne f1 = do
       let (baseFileName,ext) = splitExtension f1
           f2 = (baseFileName ++ ".refactored" ++ ext)
-      (HieDiff f s d) <- diffFiles f1 f2
-      f' <- liftIO $ makeRelativeToCurrentDirectory f
-      s' <- liftIO $ makeRelativeToCurrentDirectory s
-      return (HieDiff f s d)
+      diffFiles f1 f2
   diffs <- mapM diffOne changedFiles
   return (RefactorResult diffs)
 

hie-hare/hie-hare.cabal

@@ -11,6 +11,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   exposed-modules:     Haskell.Ide.HaRePlugin
   build-depends:       base >= 4.7 && < 5
@@ -27,4 +31,6 @@ library
                      , transformers
                      , vinyl >= 0.5 && < 0.6
   ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010

hie-ide-backend/hie-ide-backend.cabal

@@ -11,6 +11,10 @@ build-type:          Simple
 -- extra-source-files:
 cabal-version:       >=1.10
 
+flag pedantic
+  Description: Enable -Werror
+  Default:     False
+
 library
   exposed-modules:     Haskell.Ide.IdeBackend
   build-depends:       aeson
@@ -28,4 +32,6 @@ library
                      , transformers
                      , vinyl
   ghc-options:         -Wall
+  if flag(pedantic)
+     ghc-options:      -Werror
   default-language:    Haskell2010

hie-plugin-api/Haskell/Ide/Engine/Monad.hs

@@ -5,19 +5,12 @@
 
 module Haskell.Ide.Engine.Monad where
 
-import           Control.Concurrent
-import           Control.Concurrent.MVar
 import           Control.Exception
 import           Control.Monad.IO.Class
 import           Control.Monad.State.Strict
-import           Data.Char
 import           Haskell.Ide.Engine.PluginDescriptor
 import qualified Language.Haskell.GhcMod.Monad as GM
 import qualified Language.Haskell.GhcMod.Types as GM
-import qualified Language.Haskell.GhcMod.Utils as GM
-import qualified Language.Haskell.GhcMod.Debug as GM
-import           System.Directory
-import           System.IO.Unsafe
 -- ---------------------------------------------------------------------
 
 runIdeM :: IdeState -> IdeM a -> IO a