This repository was archived by the owner on Oct 7, 2020. It is now read-only.
ghc-mod 5.5 #176
Merged
ghc-mod 5.5 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated, currently requires a yet to be merged HaRe pr. |
Now the cwd is only changed at startup, which means that every cabal project requires it’s own hie instance.
fixes haskell#175 fixes haskell#156 fixes haskell#161
Currently ghc-mod calls trys to launch itself again for this. This will be fixed in an upcoming release and then we can switch it on again.
cocreature
force-pushed
the
ghc-mod-5.5
branch
from
6b5fd5b to
1190e8d
Compare
|
Travis is finally happy (after running out of memory multiple times, because for some reason the cache got cleaned), so as soon as somebody has time to look over it we can merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the cwd is only changed at startup, which means that every cabal
project requires it’s own hie instance.
This is not finished, but I thought that it might be easier to fix the remaining issues if we have something to look at.
In particular HaRe needs to expose functions that work in
GhcModTinstead of trying to setup it’s own ghc-mod session since that no longer works with ghc-mod 5.5.Also the ide bindings need to be updated. They simply need to pass in the directory with the cabal file or any subdirectory of that (ghc-mod figures the root out in that case). They can either do that by starting
hiewith the correct cwd or by using-r projectdir. On the emacs front we can probably simply abuse haskell-mode’s session management to have onehieinstance per project.