This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Async dispatch #72
Merged
Async dispatch #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,8 +36,8 @@ jsonStdioTransport cin = do | |||
| putStr $ show (HieError (A.String $ T.pack $ show err)) | |||
| loop (cid + 1) stream' | |||
| Just (Right r) -> do | |||
| writeChan cin (wireToChannel cout cid r) | |||
| rsp <- readChan cout | |||
| atomically $ writeTChan cin (wireToChannel cout cid r) | |||
There was a problem hiding this comment.
Even if the plugin is async we block completely at this point, which seems like the wrong thing to do, since we don't gain anything from having async that way. But we should probably try to get the reworked jsonStdioTransport before changing that.
There was a problem hiding this comment.
Also we can do that in a separate pr.
There was a problem hiding this comment.
I have not touched the transport side, pending the STX PR.
Once it is done, this will have to be split into two processes, one which reads on stdio and writes to the Chan to the dispatcher, the other waits on the return Chan and relays on to stdout.
But better not to mix two things at once, it can wait.
A given plugin/plugin command can operate in asynchronous fashion. Only the reply path mechanism is given, it is up to the plugin to do whatver makes sense for the specific plugin to deal with the async action.
alanz
force-pushed
the
async-dispatch-1
branch
from
d833fab to
75c6ed7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
A plugin can decide on a per-command basis whether it should have the option to return an async result.
If so, it takes responsibility for managing whatever threads are required to create the async processing, but each message has a callback function for when the result is ready.