Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky diagnostics #1171

Closed
pepeiborra opened this issue Jan 8, 2021 · 1 comment · Fixed by #1188
Closed

Sticky diagnostics #1171

pepeiborra opened this issue Jan 8, 2021 · 1 comment · Fixed by #1188
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@pepeiborra
Copy link
Collaborator

I have seen a redundant import warning refusing to go away after clearing the import, and I believe this could well be an unintended consequence of haskell/ghcide#959

I haven't been able to reproduce it consistently, much less to create a failing test. Just recording it here as a known issue for now.
@wz1000
Copy link
Collaborator

wz1000 commented Jan 8, 2021

I have also been seeing similar problems with typechecking errors sticking around after they should have been fixed since I rebased my hiedb branch a couple of days ago, but didn't report as I wasn't sure if it was my fault.

@jneira jneira added component: ghcide status: needs repro type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Jan 8, 2021
pepeiborra added a commit that referenced this issue Jan 10, 2021
@pepeiborra
Add a test for #1171
3ddda67
pepeiborra added a commit that referenced this issue Jan 10, 2021
@pepeiborra
Store diagnostics in values ref (fixes #1171)
8128d54
@pepeiborra pepeiborra mentioned this issue Jan 10, 2021
Merged
@mergify mergify bot closed this as completed in #1188 Jan 10, 2021
mergify bot pushed a commit that referenced this issue Jan 10, 2021
@pepeiborra
Fix sticky diagnostics (#1188)
63218d1 
* Add a test for #1171

* Refactor: extract more types from Core.Shake

* Store diagnostics in values ref (fixes #1171)
fendor pushed a commit to fendor/haskell-language-server that referenced this issue Jan 11, 2021
@pepeiborra @fendor
Fix sticky diagnostics (haskell#1188)
361c0e6 
* Add a test for haskell#1171

* Refactor: extract more types from Core.Shake

* Store diagnostics in values ref (fixes haskell#1171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sticky diagnostics haskell/haskell-language-server
3 participants
@pepeiborra @jneira @wz1000