Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hls-plugin-api 0.7.1.0 breaks haskell-language-server 0.9.0.0 #1395

Closed
hamishmack opened this issue Feb 18, 2021 · 4 comments · Fixed by #1392
Closed

hls-plugin-api 0.7.1.0 breaks haskell-language-server 0.9.0.0 #1395

hamishmack opened this issue Feb 18, 2021 · 4 comments · Fixed by #1392
Labels
CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@hamishmack
Copy link

I think we need to add a hls-plugin-api ==0.7.0.* constraint like the one for ghcide (see #1332 and #1381)
@hamishmack
Copy link
Author

I also think we might need hls-retrie-plugin ==0.1.1.0

@hamishmack hamishmack mentioned this issue Feb 18, 2021
Merged
@jneira jneira added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. CI Continuous integration labels Feb 18, 2021
@pepeiborra
Copy link
Collaborator

I have added restrictions for hls-plugin-api and all the plugins

@pepeiborra
Copy link
Collaborator

Leaving this ticket open until the restrictions are merged in HEAD

@pepeiborra pepeiborra mentioned this issue Feb 18, 2021
Merged
@jneira jneira linked a pull request Feb 24, 2021 that will close this issue
Bump plugins versions #1392
Merged
@jneira
Copy link
Member

jneira commented Feb 24, 2021

Closed by #1392

@jneira jneira closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump plugins versions pepeiborra/ide
3 participants
@pepeiborra @jneira @hamishmack