Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugins versions #1392

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Bump plugins versions #1392

merged 3 commits into from
Feb 19, 2021

Conversation

pepeiborra
Copy link
Collaborator

The plugins were all updated to lsp-1.0 in #1284 and need a minor version bump in order to be upload able to Hackage.

I am also going to upload all the plugins I have Hackage maintainer access (class, imports, and retrie). This is in order to make them usable with ghcide 0.7.5.0, which was released earlier today.

Ideally we would have a CI job that would detect Cabal version updates and automatically upload to Hackage.

@jneira
Copy link
Member

jneira commented Feb 18, 2021

Ideally we would have a CI job that would detect Cabal version updates and automatically upload to Hackage.

As proposed in #1310

@jneira
Copy link
Member

jneira commented Feb 18, 2021

Maybe hls-plugin-api should hide lsp to plugins (and ghcide?), with reexports or something, to cut at least in some cases the upgrade in cascade

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i've added you to the maintainer group of hls-hlint-plugin, but i can do the upload if you are busy

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Feb 18, 2021
@pepeiborra
Copy link
Collaborator Author

Updated also the minBounds in haskell-language-server.cabal. I am tempted to make these hard bounds (==) instead of minBounds to avoid cabal install failures as seen in #1395

@jneira
Copy link
Member

jneira commented Feb 18, 2021

please take a look to #1310 before merging

@pepeiborra
Copy link
Collaborator Author

@jneira What do you mean???

@mergify mergify bot merged commit 7d3cf87 into haskell:master Feb 19, 2021
@jneira
Copy link
Member

jneira commented Feb 19, 2021

in that issue we were debating about bump up all project packages to 1.0 , in the face of a next hackage release
as this pr was mainly bumping out package versions we could did that change here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hls-plugin-api 0.7.1.0 breaks haskell-language-server 0.9.0.0
2 participants