Skip to content

hls-stylish-haskell-plugin tests are failing when running from hackage tarball #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixonmars opened this issue May 10, 2021 · 1 comment · Fixed by #1819
Closed

hls-stylish-haskell-plugin tests are failing when running from hackage tarball #1818

felixonmars opened this issue May 10, 2021 · 1 comment · Fixed by #1819
Labels
old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@felixonmars
Copy link
Contributor

Your environment

Building hls-stylish-haskell-plugin-1.0.0.0 for Arch Linux.

Which OS do you use:
Arch Linux x86_64

Steps to reproduce

Run tests from a hackage tarball

Actual behaviour

Running 1 test suites...
Test suite tests: RUNNING...
stylish-haskell
  formats a document: FAIL (2.04s)
    Test output was different from 'test/testdata/StylishHaskell.formatted_document.hs'. Output of ["git","diff","--no-index","--text","--exit-code","test/testdata/StylishHaskell.formatted_document.hs","/tmp/StylishHaskell.formatted_document2685-3.actual"]:
    diff --git a/test/testdata/StylishHaskell.formatted_document.hs b/tmp/StylishHaskell.formatted_document2685-3.actual
    old mode 100755
    new mode 100644
  formats a range:    FAIL (3.77s)
    Test output was different from 'test/testdata/StylishHaskell.formatted_range.hs'. Output of ["git","diff","--no-index","--text","--exit-code","test/testdata/StylishHaskell.formatted_range.hs","/tmp/StylishHaskell.formatted_range2685-5.actual"]:
    diff --git a/test/testdata/StylishHaskell.formatted_range.hs b/tmp/StylishHaskell.formatted_range2685-5.actual
    old mode 100755
    new mode 100644

2 out of 2 tests failed (3.77s)
Test suite tests: FAIL
Test suite logged to: dist/test/hls-stylish-haskell-plugin-1.0.0.0-tests.log
0 of 1 test suites (0 of 1 test cases) passed.

It appears to be file permission differences. Perhaps the tests should ignore these differences?

@Ailrun
Copy link
Member

Ailrun commented May 10, 2021

Oops, yes, the test command should use -c core.fileMode=false.

@Ailrun Ailrun added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: testing labels May 10, 2021
@mergify mergify bot closed this as completed in #1819 May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old_type: distribution type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants