Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore filemode in diff #1819

Merged
merged 1 commit into from
May 11, 2021
Merged

Ignore filemode in diff #1819

merged 1 commit into from
May 11, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented May 11, 2021

Resolves #1818

berberman
berberman approved these changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, perhaps this was caused by running the test in chroot?

@Ailrun
Copy link
Member Author

Ailrun commented May 11, 2021 •
edited
Loading

@berberman why does chroot change the permission in that way? Could you please explain more on that?

@Ailrun Ailrun added the merge me Label to trigger pull request merge label May 11, 2021
@mergify mergify bot merged commit 4e95b99 into haskell:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berberman berberman berberman approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hls-stylish-haskell-plugin tests are failing when running from hackage tarball
2 participants
@Ailrun @berberman