Suggest completions only from imported libraries

[micahcantor]

Is your feature request related to a problem? Please describe.

I really like HLS, but it is frustrating and slow how it seems to suggest completions not only from currently imported libraries, but from any library possible. Even with a small amount of dependencies this makes the amount of suggested completions massive and at least for me makes VSCode run quite sluggish. It also somewhat often makes it so I can't find the function I'm looking for, since the exact same (or very similar) functions are exported from 10 different libraries.

Describe the solution you'd like
I'd like an option to have suggestions only show for libraries that are currently imported in the current file.

[jneira]

Hi, thanks for reporting the issue. there had been other users reporting similar problems, see #2440 for example. It is suggesting another solution, restrict imports to configured list of libraries but the unwanted behaviour behind it is the same afaik.

The restriction cant be the default one as there will be people want suggestions from still not imported libs in the module.
So i can think of two possible paths, not excluyent:

• improve ordering of suggestion, putting firs symbols from already imported libs
• establish a configured filter

Otoh, what hls version are you using?, there have been improvements in import suggestions in 1.5.0

[micahcantor]

Hm yeah I do agree it wouldn't need to be default. I also was on 1.4 but just upgraded to 1.5, it's great that suggestions are already being improved in that release.

I think having some kind of filter one where to search for symbols to include is a pretty good idea. I would say that when using qualified imports, suggestions there are good since it only shows within that library, my main issues are with the UX of general completions on type.

[michaelpj]

At least it would be relatively cheap and safe to add an option for this? It seems like the sort of thing where I expect people will have conflicting opinions on an ongoing basis, so we should just make it configurable.

[pepeiborra]

Config options are a poor substitute for a universally great user experience. I don't want us to rush and implement poor workarounds on the basis of a number of 0.1 bugs in the previous HLS release.

[michaelpj]

Ah, this might also have been alleviated by the recent improvements to the completion item sorting.