Attach windows binaries for ghc 8.8.4

[jneira]

As it is difficult to make ci generate those windows binaries but it is doable locally, i think we could try to attach my local windows versions.
I am gonna follow the naming conventions of the existing ones and attach them manually asap, if no one disagree.

/cc @bubba

[lukel97]

That would be perfect!

[jneira]

I've attached binaries in the 0.2.2 release:

• https://github.com/haskell/haskell-language-server/releases/download/0.2.2/haskell-language-server-Windows-8.8.3.exe.zip
• https://github.com/haskell/haskell-language-server/releases/download/0.2.2/haskell-language-server-Windows-8.8.4.exe.zip

I would keep this open to track the manual upload of those versions, while they are not available via ci

[lukel97]

Is 8.8.2 completely unbuildable on windows?

[jneira]

it was last time i tried it but not sure it it worths the time to try it again: two minor versions released and 5 months since the last 8.8.2 stackage lts

[lukel97]

@jneira I’ve kicked off the 0.3.0 pre-release, whenever you're able can you upload some windows binaries for ghc-8.8.3 and 8.8.4 at some point? I'll wait for them before untagging it as pre-release

[jneira]

Sure, i'll upload them asap

[jneira]

@bubba done!

[lukel97]

Hi @jneira , @alanz has made the 0.4.0 release could you upload some binaries for those on 8.8.4 and 8.8.3 as well?

[jneira]

Sure, i uploaded 8.8.3, 8.8.4 and 8.10.2 last night

[alanz]

Can we close this?

[jneira]

Well, we will need to upload manually windows versions hard to install in a ci env.
Stackage is using 8.8.4 for lts and 8.10.2 for nightly (with a windows workaround) so there is chances that users will need them.
I would continue uploading until newer versions are released and stackage is updated to use them.

[alanz]

Oops, sorry, I thought this related to the 0.4.0 tag specifically.

[lukel97]

@jneira 0.5.0 has been tagged, can you upload some binaries again whenever you're free? https://github.com/haskell/haskell-language-server/releases/tag/0.5.0

Btw, should we be also bumping hls-plugin-api to 0.5.0?

[jneira]

I did a diff between master and 0.4.1.0 and there is no differences, I will double check it just in case.

EDIT: git diff 0.5.0 hls-plugin-api-0.4.1.0 -- .\hls-plugin-api\ does show nothing

[jneira]

• binaries for hls-0.5.0 already uploaded

[lukel97]

@jneira can you do binaries for 0.5.1 at some point?

[jneira]

yeah, but I will not able to do it until tomorrow at night (UTC)

[lukel97]

@jneira No rush, once you upload them can you uncheck the pre-release button? Thanks again as always!

[jneira]

@bubba uploaded and pre button unchecked!

[jneira]

Added missing windows binaries for 0.6.0

[jneira]

As we added 8.10.2 to cu, that version not need to be generated locally

[jneira]

To alliviate the manual generation of binaries i popose drop support for the ghc-8.8.3 binary and only relase ghc-8.8.4.
If nobody disagree i will do it in the next release. If some user explicitly ask for it we can attach it.

[alanz]

Sounds good to me

[Ailrun]

Also agreed.

[Ailrun]

@jneira Could you upload HLS-8.8.4 for Windows?

[jneira]

my laptop is on heat, i ll try to upload it this evening gmt

[jneira]

This time i am not able to install hls for ghc-8.8.4, it fails continously with segfaults building floskell.
@Ailrun Maybe we should make definitive the release and hope not many windows users continue being using ghc-8.8.4
I'll continue trying

[Ailrun]

Hm... does it work without floskell?

[jneira]

Hm... does it work without floskell?

I want to try some tricks including it to get the full build but that is a good alternative if everything else fails.
However i did not want make rest of users continue waiting and ghc-8.10.4 is a good version for windows so we always can suggest upgrade it. I cant continue trying to build until this night gmt.
The release has been made public via ghcup and vscode users still cant upgrade so...

[Ailrun]

However i did not want make rest of users continue waiting and ghc-8.10.4 is a good version for windows so we always can suggest upgrade it.

Agreed. I will make the pre-release be a real release.

P.S. done.

[jneira]

@Ailrun many thanks, i know make the release can be a little bit stressing and you have done a perfect work 😄

[Ailrun]

@jneira it's all my words, thank you for all your help for the release :)

[jneira]

Finally i've got to build it and it is already included in the release 😄

Using -j1, cabal build instead cabal install and setting floskell as local package 😅

[Ailrun]

If we can create a binary reliably with that setting, how about put things back to Github Actions?

[jneira]

mmm iirc in the CI windows environment the bug is more persistent, but maybe could work, good idea (the script would be more complex though)

[jneira]

I am installing locally 1.2.0 for ghc-8.8.4

[jneira]

This time i am not able to avoid the segfault easily, i am trying with

package floskell
    ghc-options: -O0

😟

[jneira]

No need for more manual builds thanks to #2199