-
-
Notifications
You must be signed in to change notification settings - Fork 388
Issues upgrading to recent hls commit and ghc 9.2.5 for company codebase #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you disable dynamic linking, then TH is not supported. |
@hasufell Does |
Yes. haskell-language-server/haskell-language-server.cabal Lines 209 to 212 in 9e5fc88
|
@hasufell Oh I understand It looks like we compile with this because otherwise we get errors mounting our cabal store as a docker volume. I suppose that means we either need to abandon cabal store as a docker volume or go without hls. |
We'd like to keep using the cabal store as a docker volume... so is there a way we can tell HLS to use another store for its "core libraries"? Removing
|
You can bundle HLS libraries like we do in the bindists and build your own bindists. See the |
@hasufell I'll take a look again later, but I'm new to the bindist concept and searches only bring up a gentoo tool called bindist. As a result reading over those files and their many variables made it hard for me to develop a concrete understanding of what exactly is happening there. Then researching bindist didn't come up with much. This seems like one of those "everyone should already know so no one wrote the concept down" type things which I'm lucky enough to not know. Thanks for your help though. |
No, bindist has nothing to do with gentoo. Those are simply .tar bundles of binaries. |
I'm closing this because we successfully upgraded to ghc 9.4.4 and hls 1.9.1.0. There are still some issues but I'll create those separately |
This is going to be a tracking issue for some things blocking my company from upgrading to ghc 9.2.5 because HLS at 85f7881 isn't working with it.
First I'll list out the issues and then I'll replace the text with a link to existing issues or create new ones where appropriate.
Note replicate my experience with this vscode devcontainer by cloning this repo and see issues I've managed to reproduce from the company codebase in a minimal environment with few moving pieces.
seem to prevent normal usage
HLS binary does not support template Haskell
This issue is well-known and has a well-known fixe... the problem is in our docker container we compile hls with ghcup as follows:
To my understanding, compiling with the above should avoid this template haskell support issue.
aside: The RTS options were necessary for our CI to not run out of memory.
error:
Cannot derive instance via ‘"Evoke"’ (see evoke library)
Full error:
For code from reproduction repo here
This one is strange because:
cabal build
doesn't report any errors with ghc 9.2.5, but hls with ghc 9.2.5 doesexplicit-fixity: InternalError: ExplicitFixity: Unable to get fixity
This one is new to me and I have no idea why I'd get this error or what could be causing it.
seem to be non-critical
cabal.project
#3074Here is a full log most of the above issues were derived from
Cloning this repo and opening the devcontainer in vscode should reproduce this log for you (roughly):
full log
The text was updated successfully, but these errors were encountered: