Skip to content

Completion of GHC options inOPTIONS_GHC doesn't properly handle -s #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
konsumlamm opened this issue Dec 17, 2023 · 2 comments
Closed

Completion of GHC options inOPTIONS_GHC doesn't properly handle -s #3908

konsumlamm opened this issue Dec 17, 2023 · 2 comments
Labels
component: ghcide level: easy The issue is suited for beginners type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@konsumlamm
Copy link

Your environment

Which version of GHC do you use and how did you install it?

9.8.1 from GHCup

Which version of HLS do you use and how did you install it?

2.5.0.0

Steps to reproduce

{-# OPTIONS_GHC -ddump-simpl -dno-suppr #-}

When typing -dno-suppr, select the -dno-suppress-type-signatures suggestion.

Expected behaviour

{-# OPTIONS_GHC -ddump-simpl -dno-suppress-type-signatures #-}

Actual behaviour

{-# OPTIONS_GHC -ddump-simpl -dno-dno-suppress-type-signatures #-}
@konsumlamm konsumlamm added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Dec 17, 2023
@fendor fendor added component: ghcide level: easy The issue is suited for beginners and removed status: needs triage labels Dec 17, 2023
@michaelpj
Copy link
Collaborator

I suspect it's not so much the dashes as that it's not correctly handling the presence of a partial prefix at all. We should be able to support that!

@konsumlamm
Copy link
Author

I think it is the dashes, if I type -ddum and select the -ddump-asm suggestion, it works as expected.

jhrcek added a commit to jhrcek/haskell-language-server that referenced this issue Feb 1, 2024
jhrcek added a commit to jhrcek/haskell-language-server that referenced this issue Feb 4, 2024
jhrcek added a commit to jhrcek/haskell-language-server that referenced this issue Feb 9, 2024
@jhrcek jhrcek closed this as completed in 1bbe780 Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ghcide level: easy The issue is suited for beginners type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

3 participants