-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Tokens treats a standalone deriving strategy as type parameter #3983
Closed
Tracked by
#3931
Labels
component: semantic-tokens
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Comments
konn
added
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
status: needs triage
labels
Jan 19, 2024
Thank you for your bug report. Interesting case, I’ll take a look later |
This comment was marked as resolved.
This comment was marked as resolved.
I can reproduce now. It seems the type variable
possible fix would be walk to along with the lexed source: #3958 (comment), to prevent the generated token from appearing |
shoud be fixed by #3958. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: semantic-tokens
type: bug
Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Your environment
Which OS do you use? macOS Sonoma14.2.1(23C71)
Which version of GHC do you use and how did you install it? GHC 9.2.8 via GHCup
How is your project built (alternative: link to the project)? By
cabal-install
. This can happen in any project, but seelinear-extra
.Which LSP client (editor/plugin) do you use? VSCode
Which version of HLS do you use and how did you install it? 2.6.0.0, via ghcup-vanilla-0.0.8.
Have you configured HLS in any way (especially: a
hie.yaml
file)? No. Auto Detection.Steps to reproduce
Adds a standalone deriving clause with explicit deriving strategy with Semantic Tokens enabled.
Example. Consider the following:
In above,
newtype
is treated as keyword correctly:Next, make
Hashable
instance deriving standalone:Then
newtype
is rendered differently!Changing
newtype
toanyclass
gives the same effect. If we change it tovia LocAddr_
,via
is rendered correctly.Expected behaviour
Both
newtype
andanyclass
must be treated as keyword.Actual behaviour
Treated as parameter, as above. Here is the token inspection result from VSCode:
Debug information
Here is the trace log of VSCode:
vscode.log
The text was updated successfully, but these errors were encountered: