Skip to content

Update hls-plugin-api on Hackage #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Galagora opened this issue Sep 15, 2020 · 4 comments · Fixed by #439
Closed

Update hls-plugin-api on Hackage #404

Galagora opened this issue Sep 15, 2020 · 4 comments · Fixed by #439
Labels
CI Continuous integration component: hls-plugin-api type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@Galagora
Copy link

The current version fails to build with error:

src/Ide/Plugin/GhcIde.hs:42:7: error:
    Variable not in scope:
      executeAddSignatureCommand
        :: Language.Haskell.LSP.Core.LspFuncs Ide.Plugin.Config.Config
           -> IdeState
           -> ExecuteCommandParams
           -> IO
                (Either ResponseError Value,
                 Maybe (ServerMethod, ApplyWorkspaceEditParams))
   |
42 |     = executeAddSignatureCommand lf ide (ExecuteCommandParams "typesignature.add" (Just (List [toJSON params])) Nothing)
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^

Updating this is the only straightforward way to build haskell-language-server in Nixpkgs.

@jneira jneira added CI Continuous integration type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: hls-plugin-api labels Sep 15, 2020
@jneira
Copy link
Member

jneira commented Sep 15, 2020

thanks for the bug report, we should test the package install in isolation

@Galagora
Copy link
Author

The build works in master, it's just a matter of updating the version that's on Hackage.

@jneira jneira linked a pull request Sep 16, 2020 that will close this issue
@jneira
Copy link
Member

jneira commented Sep 16, 2020

From #405

Well, i am afraid that the hackage version of hls-plugin-api cant be built standalone cause it relies in the ghcide fork that was used when it was uploaded. It fails to compile with the hackage version of ghcide 😟
That should not be like that, and i still think the next release should be done correctly, against a suitable released ghcide version.

@jneira jneira removed a link to a pull request Sep 25, 2020
@jneira jneira linked a pull request Sep 29, 2020 that will close this issue
@jneira
Copy link
Member

jneira commented Sep 29, 2020

hls-plugin-api-0.4.1.0, compatible with ghcide-0.4.0, has been released:

@jneira jneira closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration component: hls-plugin-api type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants