You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is not as trivial as to simply generate the globalOn field for each plugin, as this exposes internal plugins to the outside world as well, in particular:
"LSPRecorderCallback": {
"globalOn": true
},
which is not something we want to do, I believe.
Alternatively, we could add options for Goto Definition handlers to handlersToGenericDefaultConfig. I think that's directly at odds with #4094, but perhaps still worth it.
In #4126, I noticed the CI was green, even though the PR doesn't modify the vscode extension schema json file.
The reason seems to be in https://github.com/haskell/haskell-language-server/blob/master/hls-plugin-api/src/Ide/Plugin/ConfigUtils.hs#L114, we only generate an "Enable Plugin" config, if there is exactly one other config. However, we don't generate a config for
Goto Definition
handlers.I think, we should also generate an "Enable Plugin" Config, if no other config exists.
The text was updated successfully, but these errors were encountered: