Add Qualified imports with types

[emilypi]

Hi all,

I would very much appreciate the ability to have an import of the form

import Namespace.Module (<types declared in module>)
import qualified Namespace.Module as Module 

Would it be possible to provide this? It seems like a fairly deterministic pattern to replicate with a few easily solvable conflicts. Thoughts?

[googleson78]

Do you want Module from your example to only be the "last" part of the module name? e.g. Lazy from Data.Map.Lazy
or should Namespace only be the "first" part (Data with the above example)

Seems like there might need to be some heuristic for this, as you one can find counterpoints for both "styles" :/

[pepeiborra]

We already have qualified and unqualified import suggestions. Do you think even more automation would be helpful?

Screen.Recording.2020-12-25.at.11.01.55.mov

[jneira]

@emilypi do you think that feature continue being sensible having qualified and unqualified import suggestions (as commented above)?

[emilypi]

@jneira sorry it took so long to get back to this! I've been using HLS and have used the (non-)qualified imports feature - it works fine. Perhaps we could figure out what automation looks like for this, because the idea is rather simple and pervasive in haskell code. Consider the Map.member example above:

f :: Map Int a -> Bool 
f = Map.member 0 

This will correspond with the prompt for import qualified Data.Map as Map. Often, what i'd like from such an import is to not add additional verbose imports ala f :: Map.Map Int a -> Bool - I'd like to import the qualified import along with the exposed type, like so:

import Data.Map (Map(..))
import qualified Data.Map as Map

Now, I can do this in series of two automated clicks: one for the qualified import and then one for the the type import. My ask is this: is it possible or even sensible to combine this into a single action? For example a prompt for "would you like to import qualified with type?" I understand how trivial this sounds, but it is the common pattern among most production code i've seen, so it would be a noticeable quality of life improvement. I do think it's sensible, if a small request. Little things like this make the experience extremely pleasant 😄

[jneira]

Thanks for your thoughtful response: yeah, i recognize that pattern is very common and it would very nice apply it in one go.
Not sure how we could do it (we dont use prompts for now) , but at very least we could hardcode the most used ones (like Map)

[emilypi]

That seems like an okay thing to hardcode at this point if it's difficult with the existing machinery.