Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete global hie.yaml config #1230

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Delete global hie.yaml config #1230

merged 4 commits into from
Jan 19, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 19, 2021

Closes #741

Ailrun
Ailrun approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Jan 19, 2021
@pepeiborra
Copy link
Collaborator

Did you see my last comment in the issue discussion?

One situation where it's unclear whether the implicit cradle works at all is when the hls wrapper is being used to detect the version of ghc before downloading binaries. I think this scenario requires further testing with the implicit cradle

@mergify mergify bot merged commit b303369 into haskell:master Jan 19, 2021
@jneira
Copy link
Member Author

jneira commented Jan 19, 2021

@pepeiborra yep, but afaiu it is not related with the deletion of these files in hls (they are not the actual used ones but templates), otoh @beberman has used hls without hie.yaml and worked fine so i assumed at least for hls we could get ride of it. I am using hls in projects without it and hls-wrapper chooses the correct ghc.

Maybe does it worth open a new issue with that concern?

@jneira jneira deleted the drophieyaml branch January 19, 2021 13:08
@peterwicksstringfield peterwicksstringfield mentioned this pull request Jan 20, 2021
Closed
sir4ur0n pushed a commit to sir4ur0n/haskell-language-server that referenced this pull request Oct 29, 2021
Update documentation on using HIE with HLS
26f55de 
Followup of haskell#1230
@sir4ur0n sir4ur0n mentioned this pull request Oct 29, 2021
Merged
mergify bot pushed a commit that referenced this pull request Oct 29, 2021
@sir4ur0n
Sir4ur0n/doc/cleanup hie (#2311)
b018717 
* Update documentation on using HIE with HLS

Followup of #1230

* Cleanup some documentation links that are not visible with inline code
pepeiborra pushed a commit that referenced this pull request Nov 2, 2021
@sir4ur0n @pepeiborra
Sir4ur0n/doc/cleanup hie (#2311)
cb3416f 
* Update documentation on using HIE with HLS

Followup of #1230

* Cleanup some documentation links that are not visible with inline code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete global cradle files (hie-cabal.yaml, hie-stack.yaml)
3 participants
@jneira @pepeiborra @Ailrun