Break down ghcide functionality in HLS plugins #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
clean-up-handlers
branch
4 times, most recently
from
9f01f2e
to
9c98662
Compare
jneira
approved these changes
Jan 24, 2021
pepeiborra
force-pushed
the
clean-up-handlers
branch
from
9c98662
to
4d38748
Compare
This was worth doing to clean up the messy command handlers
Previously defined together with the type lenses command handler
pepeiborra
force-pushed
the
clean-up-handlers
branch
from
4d38748
to
fcb21c2
Compare
We might want to break them down into multiple HLS plugins later on (local, non local, and module header).
pepeiborra
force-pushed
the
clean-up-handlers
branch
from
fcb21c2
to
5bf939e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work started in #701 to split out ghcide functionality in HLS plugins.
Splitting provides several benefits:
Later on, we may want to break completions down further as discussed in #724
Closes #724