-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore code actions order #1273
Conversation
An unfortunate side effect of recent changes is that the extend import suggestions ended up at the bottom of the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add some tests about the ordering would be great, to not break it (relative between different kinds of?)
Such tests would require adjustment every time a new code action is added, an existing code action is changed, etc. So I'm not keen on adding them, some tests are more trouble than they're worth. But if anyone else wants to do it, I won't oppose either. |
we could check at least the preferred ones are below the cut limit, but definitely not in this pr |
An unfortunate side effect of recent changes is that the extend import suggestions ended up at the bottom of the list.
This change puts back all code actions provider together so they can be reordered more easily, and restores the previous order where extend imports would be near the top of the list