Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare hls hlint plugin 0.2.0 #1296

Merged
merged 6 commits into from
Feb 4, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Feb 2, 2021

@jneira jneira force-pushed the prepare-hls-hlint-plugin-0.2.0 branch from 6b3d88e to 990c392 Compare February 2, 2021 22:11
@jneira
Copy link
Member Author

jneira commented Feb 3, 2021

The build is failing for ghc-8.6 with

Failed to build mmorph-1.1.4.
Build log (
/home/runner/.cabal/logs/ghc-8.6.4/mmorph-1.1.4-15531b2150bdb70455c97dbadcc62c6adb5af02d44a217c6b4d71a41948a0134.log
):
Configuring library for mmorph-1.1.4..
cabal: Failed to build mmorph-1.1.4 (which is required by test:func-test from
hls-0.9.0.0 and test:wrapper-test from hls-0.9.0.0). See the build log above
for details.

Preprocessing library for mmorph-1.1.4..
Building library for mmorph-1.1.4..
[1 of 2] Compiling Control.Monad.Morph ( src/Control/Monad/Morph.hs, dist/build/Control/Monad/Morph.o )

src/Control/Monad/Trans/Compose.hs:60:7: error:
    Not in scope: type constructor or class ‘MonadFail’
   |
60 |     , MonadFail
   |       ^^^^^^^^^

No sure if due the new hackage index or ghc-exactprint, investigating 😟

@jneira
Copy link
Member Author

jneira commented Feb 3, 2021

The package mmorph has a recent suspicious revision: https://hackage.haskell.org/package/mmorph-1.1.4/revisions/ bumping out the base lower bound (after a recent version upload)

@jneira
Copy link
Member Author

jneira commented Feb 4, 2021

@Ailrun @pepeiborra we need some approval to continue with the release 🙂

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry, I thought I approved this.

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Feb 4, 2021
@mergify mergify bot merged commit 8c7b97b into haskell:master Feb 4, 2021
jneira added a commit that referenced this pull request Feb 4, 2021
* Bump up version of hls-hlint-plugin to 0.2.0

* Use ghc-exactprint-0.6.3.4

* Update hackage index to get mmorph revision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants