Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code action for hiding shadowed identifiers from imports #1322

Merged
merged 17 commits into from
Feb 13, 2021
Merged

Add code action for hiding shadowed identifiers from imports #1322

merged 17 commits into from
Feb 13, 2021

Conversation

berberman
Copy link
Collaborator

@berberman berberman commented Feb 8, 2021 •
edited
Loading

Closes #156

Peek

TODO:

  • Handle the case where we need perform hiding on multiple import decls simultaneously
  • Write tests

@berberman berberman marked this pull request as ready for review February 10, 2021 13:02
jneira
jneira approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice code action, lgtm

@berberman
Copy link
Collaborator Author

I made changes in deleteFromImport and hideImplicitPreludeSymbol, and used TypeCheck rule in ghcide code action, so I want to ask review from @konn and @pepeiborra.

konn
konn approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat! And thank you for an aesthetic improvement for trailing comma!

pepeiborra
pepeiborra approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Feb 12, 2021
@mergify mergify bot merged commit a9b796c into haskell:master Feb 13, 2021
@berberman berberman deleted the hide-id branch February 13, 2021 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

@pepeiborra pepeiborra pepeiborra approved these changes

@konn konn konn approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code action for hiding imports
4 participants
@berberman @konn @pepeiborra @jneira