Fix completion snippets on DuplicateRecordFields #1360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #682
According to GHC Wiki:
When DuplicateRecordFields is enabled, field accessors become "selectors". For example, the corresponding
GlobalRdrElt
of abovex
isx |-> GRE $sel:x:MkT (FldParent T (Just x)) LocalDef
. So we can't usegre_name
($sel:x:MkT
) for completion, butpar_lbl
(x
) of its parent.In this PR, item names are converted into
OccName
s before passed tomkNameCompItem
, resulting in no renamed filed selector occuring in the result.