Sanitize the setup of the default Ide.Config #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like HLint plugin requires some changes too. |
there isn't a sensible way to fix it, so I just plugged in the type error and let the lsp 1.0 PR take care of it |
pepeiborra
force-pushed
the
defaultHlsConfig
branch
from
a824263
to
3c8808a
Compare
Ailrun
reviewed
Feb 13, 2021
pepeiborra
force-pushed
the
defaultHlsConfig
branch
from
bee019e
to
d73f70e
Compare
|
@jneira I'm dropping the "ghcide does not support update config" test. Shout if you want to keep it |
|
@pepeiborra that test is already dropped in my lsp-1.0 PR. |
|
I will not miss it, thanks for cleaning it out |
pepeiborra
force-pushed
the
defaultHlsConfig
branch
from
d73f70e
to
468ef66
Compare
|
This keeps failing with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a field in the
defaultMaindriver to specify the default config, replacing two callbacks and making things a bit saner.The rest of the changes are to deal with the use of
defin various places which had to be turned into a parameter.