Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display package names of external libraries on hover #1626

Merged
merged 11 commits into from
Jul 3, 2021

Conversation

berberman
Copy link
Collaborator

2021-03-26

Resolves part of #686

@berberman

This comment has been minimized.

@pepeiborra
Copy link
Collaborator

"resource vanished - broken pipe" means that HLS stopped running. Either it was killed, it crashed, or it decided to exit on its own. You will need to investigate why by looking at the log output with LSP_TEST_LOG_STDERR=1

@berberman
Copy link
Collaborator Author

Server crashed with "[ERROR] Fatal error in server thread: SQLite3 returned ErrorBusy while attempting to perform step: database is locked".

I also found the error gone if I change

runWithExtraFiles :: FilePath -> (FilePath -> Session a) -> IO a
runWithExtraFiles prefix s = withTempDir $ \dir -> do
copyTestDataFiles dir prefix
runInDir dir (s dir)

to

runWithExtraFiles :: FilePath -> (FilePath -> Session a) -> IO a
runWithExtraFiles prefix s = do
  let dir = "SOME_FIXED_PATH"
  copyTestDataFiles dir prefix
  runInDir dir (s dir)

@pepeiborra
Copy link
Collaborator

#1430

@berberman berberman marked this pull request as ready for review June 23, 2021 14:11
@berberman berberman requested a review from wz1000 July 3, 2021 14:19
@berberman berberman added the merge me Label to trigger pull request merge label Jul 3, 2021
@mergify mergify bot merged commit 4ae0fea into haskell:master Jul 3, 2021
@berberman berberman deleted the hover-pkgname branch July 4, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants