Fix a wingman bug caused by mismanaged stale data #1657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wingman uses a lot of potentially stale rules, and each comes with its own position mapping. But I was stupid when I first wrote this, and didn't realize just because there results were stale didn't mean they refer to the same document.
This PR adds some type-level information, allowing me to track the age of results from Shake. By throwing an untouchable variable inside of the stale tag, the compiler makes sure I haven't accidentally scrambled ranges between different versions of the document.