Skip to content

Bump plugins in preparation for Hackage upload #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pepeiborra
Copy link
Collaborator

Please check that I haven't missed any

@pepeiborra pepeiborra requested a review from berberman April 12, 2021 17:06
@berberman
Copy link
Collaborator

Plugins' version have already been bumped in #1702. According to PVP, except eval plugin and tactics plugin, which have api-breaking changes so their major version should be bumped, we should bump ohter plugins' minor version. But all of these assume that we are using PVP -- do we have something like "HLSVP" that says plugins' releasing version should be synchronized with which of HLS?

@pepeiborra
Copy link
Collaborator Author

Much better, let's stick to the PVP then!

@pepeiborra pepeiborra closed this Apr 12, 2021
@jneira
Copy link
Member

jneira commented Apr 12, 2021

Mmm, well, we talked about set (at least) hls and plugin versions in sync, following loosely pvp:

There is an issue about establishing a policy about versioning but we it still is open:

I am not against following pvp, only want to provide some context from older releases. If we decided to follow strictly pvp, i would document it as suggested in #1434, to try to be consistent.

@berberman berberman deleted the bump-plugins branch April 13, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants