Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract floskell plugin as a standalone plugin #1829

Merged
merged 2 commits into from
May 14, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented May 13, 2021

Its basic structure is copied from hls-brittany-plugin.

@Ailrun
Copy link
Member Author

Ailrun commented May 13, 2021

Cabal configuration fails for benchmark with the following message:

 Warning: Requested index-state2021-03-29T21:23:14Z is newer than
'hackage.haskell.org'! Falling back to older state (2021-03-29T13:57:59Z).
Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: ghcide-1.3.0.0 (user goal)
[__1] rejecting: ghcide:!test (constraint from config file, command line flag,
or user target requires opposite flag selection)
[__1] trying: ghcide:*test
[__2] trying: tasty-1.4.1 (dependency of ghcide *test)
[__3] trying: ansi-terminal-0.11 (dependency of tasty)
[__4] next goal: retrie (dependency of ghcide)
[__4] rejecting: retrie-0.1.1.1 (conflict: ansi-terminal==0.11, retrie =>
ansi-terminal>=0.10.3 && <0.11)
[__4] skipping: retrie-0.1.1.0, retrie-0.1.0.1, retrie-0.1.0.0 (has the same
characteristics that caused the previous version to fail: excludes
'ansi-terminal' version 0.11)
[__4] fail (backjumping, conflict set: ansi-terminal, ghcide, retrie)
Backjump limit reached (currently 4000, change with --max-backjumps or try to
run with --reorder-goals).

Maybe we need to increase the max backjump limit? (I tried 5000, and that at least works in my machine)

Edit: In CI, 5000 does not work...

Edit2: I didn't know that cabal's backjump is non-deterministic. Sometimes 5000 does not work in my machine either...

@Ailrun Ailrun changed the title Extract floskell plugin as an independent plugin Extract floskell plugin as an standalone plugin May 14, 2021
@Ailrun Ailrun changed the title Extract floskell plugin as an standalone plugin Extract floskell plugin as a standalone plugin May 14, 2021
@Ailrun Ailrun requested review from berberman and jneira May 14, 2021 08:23
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really great (including improvements in tests), many thanks

@Ailrun Ailrun merged commit 1538140 into haskell:master May 14, 2021
@Ailrun Ailrun deleted the extract-floskell-plugin branch May 14, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants