Prepare 2021 July Release [HLS 1.3.0] #2052
Conversation
why partially? |
|
@jneira Because this PR itself does not finish the release process, as there are more things like making sure binary builds well, GHCUp coordination, Hackage release, ... |
|
Yeah, the pr is the starting point. Your plan is make the hackage release close to the github one? |
|
Yes, I think managing single-release-related things in a single issue is better for modularity |
|
|
||
| - Binaries for GHC 9.0.1 are added by @anka-213. | ||
| - Call hierarchy plugin is added, contributed by @July541. | ||
|  |
There was a problem hiding this comment.
I notice just now that call hierarchy does not work when executing it on a type signature. Is this intended, @July541?
There was a problem hiding this comment.
Yes, reference other languages' implementations, it doesn't belong to call hierarchy I think.
|
I started to work in a gh job to automate the hackage release, i hope i will able to finish it some day 😅 |
Co-authored-by: Sandy Maguire <sandy@sandymaguire.me>
Co-authored-by: Sandy Maguire <sandy@sandymaguire.me>
ChangeLog.md
Outdated
| - `:info` command is added by @akrmn. | ||
| - The plugin uses the same default language as GHCi with @fmehta's patch. | ||
| - Wingman, where most changes owing to @isovector | ||
| - An option for disabling proof state styling is added. |
There was a problem hiding this comment.
| - An option for disabling proof state styling is added. | |
| - Wingman no longer changes the fixity of function definitions. | |
| - Wingman now gives unique names to the holes it generates. | |
| - Significant improvements in Wingman's ability to reason about polymorphic and GADT types. | |
| - Wingman no longer suggests homomorphic destructs when the codomain is larger than the domain. | |
| - "Complete case constructors" support for empty lambda cases | |
| - Wingman will now give a warning if it ran out of gas during "attempt to fill hole" | |
| - Metaprogramming improvements, including symbolic-name support, and the `pointwise` combinator. | |
| - Fixed a bug when attempting to introduce too many variables in an `intros` metaprogram. |
There was a problem hiding this comment.
May I ask why you want to remove the line for proof state styling option?
Besides that,
- Fixed a bug when attempting to introduce too many variables in an
introsmetaprogram.
should this be highlighted?
There was a problem hiding this comment.
May I ask why you want to remove the line for proof state styling option?
it's the least interesting thing in the change, imo. does anyone even know what a proof state is?
|
I'm confused why not release LSP first? LSP has update about ghc 9.0 and call hierarchy, in case we can remove at least the depencency in cabal.project. |
|
we can make the release in GitHub and upload binaries cause the build uses the cabal.project |
CC: @jneira, @berberman, @pepeiborra, @isovector
Resolves partially: #1990.